Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Prometheus 3.0 #462

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat: Support Prometheus 3.0 #462

merged 1 commit into from
Nov 18, 2024

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Nov 17, 2024

Update prometheus role for 3.0.0.

  • Update argument_specs.yml to reflect support of 3.x.
  • Skip console templates on 3.x.

Fixes: #460

@SuperQ SuperQ requested a review from gardar November 17, 2024 08:50
@github-actions github-actions bot added the enhancement New feature or request label Nov 17, 2024
@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 17, 2024

I went over https://prometheus.io/docs/prometheus/3.0/migration/ and didn't find anything incompatible in our role.

Copy link
Contributor

github-actions bot commented Nov 17, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@SuperQ SuperQ force-pushed the superq/prometheus_3 branch from 9a88fa7 to 0d7b3cb Compare November 17, 2024 09:45
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 17, 2024
@SuperQ SuperQ force-pushed the superq/prometheus_3 branch from 0d7b3cb to 54b3086 Compare November 17, 2024 14:44
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 17, 2024
@SuperQ SuperQ force-pushed the superq/prometheus_3 branch from 54b3086 to 86480f6 Compare November 17, 2024 15:13
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 17, 2024
@SuperQ SuperQ force-pushed the superq/prometheus_3 branch from 86480f6 to c5dd9c8 Compare November 17, 2024 15:36
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 17, 2024
Update prometheus role for 3.0.0.
* Update argument_specs.yml to reflect support of 3.x.
* Skip console templates on 3.x.

Fixes: #460

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/prometheus_3 branch from c5dd9c8 to 9b36187 Compare November 17, 2024 17:55
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 17, 2024
@SuperQ SuperQ requested a review from gardar November 17, 2024 17:55
@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 17, 2024

Found and fixed a couple of minor issues.

  • It doesn't come with console templates anymore, but still supports them.
  • It renamed the agent feature flag to just a flag.

Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SuperQ SuperQ merged commit 818d67c into main Nov 18, 2024
59 checks passed
@SuperQ SuperQ deleted the superq/prometheus_3 branch November 18, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roles/prometheus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"only prometheus 2.x is supported" for prometheus_version
2 participants