Refactor collectors #1324
Merged
Refactor collectors #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
force-pushed
the
remove-globals
branch
13 times, most recently
from
e5ed61a to
24b7092
Compare
jkroepke
force-pushed
the
remove-globals
branch
from
24b7092 to
d3c54d4
Compare
jkroepke
force-pushed
the
remove-globals
branch
from
ee6eda1 to
11f143e
Compare
|
@breed808 please let me know if you need assistance here. |
breed808
reviewed
Nov 12, 2023
|
Thanks for the review! Sorry for the size. But i had no idea to minimize the changes. After merge, I would create an additional PR which embeddeds the wmi library, since there is no commit over years. I'm also interrest to help as maintainer here, since our company is using this exporter in production. |
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
remove-globals
branch
from
487aed9 to
087844d
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
remove-globals
branch
2 times, most recently
from
36524fc to
506e07c
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
remove-globals
branch
from
506e07c to
6824d3f
Compare
Re-add DHCP perflib dependency Fixes prometheus-community#1259 Signed-off-by: Jan-Otto Kröpke <[email protected]>
breed808
approved these changes
Nov 13, 2023
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…bals Refactor collectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1227
Fixes #1259
This PR restructors the collectors into separate packags.
Packags level variables are moved into collectors struct. This allows external libraries to call windows_exporter multiple times.
The defaults collectors are tested under Windows Server 2022 and are working fine. Test and Bench are green.
@mattdurham Maybe you can have an look here, for Grafana Agent.
@breed808 I do some test on windows server and windows server, both working fine. However maybe a RC version as pre-release should be usefull.