Method "inspect" was divided into two parts.

The functionality of one method was divided into two logically functioning parts. One method obtain offences and the other one inspects these offences.
prontolabs · Feb 22, 2018 · 1eaa11c · 1eaa11c
1 parent e471127
commit 1eaa11c
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/pronto/rubocop.rb b/lib/pronto/rubocop.rb
@@ -31,11 +31,14 @@ def valid_patch?(patch)
       ruby_file?(path)
     end
 
-    def inspect(patch)
+    def offences(patch)
       processed_source = processed_source_for(patch)
-      offences = @inspector.send(:inspect_file, processed_source).first
 
-      offences.sort.reject(&:disabled?).map do |offence|
+      @inspector.send(:inspect_file, processed_source).first
+    end
+
+    def inspect(patch)
+      offences(patch).sort.reject(&:disabled?).map do |offence|
         patch.added_lines
           .select { |line| line.new_lineno == offence.line }
           .map { |line| new_message(offence, line) }