Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python tests #102

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

ristomcgehee
Copy link
Contributor

@ristomcgehee ristomcgehee commented Jan 21, 2024

Currently the Python tests are failing on the main branch (e.g., this run) and recently updated PRs. This is due to the NPM dependencies not being installed when the python tests try to start the server.

Note that the Python tests are failing on this PR due to the way pull_request_target works. It's using the version of python-tests.yaml from the main branch which is not installing the NPM dependencies.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @ristomcgehee

@seanpmorgan seanpmorgan merged commit 06af673 into protectai:main Jan 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants