Fix Flaky Test in SubjectClosureResolver_TestCase #814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flaky test was fixed in this pull request-
Flakiness in the tests -
To check for flakiness in the tests, a tool called nondex was used.
Steps to reproduce flakiness using nondex -
Test 1:
The third command shows us the flakiness in the test. There are test failures due to differences in the order of elements
Source of Flakiness in the test and fix:
The object rootEntities is a set and sets in Java have no order. However, the check being carried out was - assertThat(rootEntities, contains(cls, valueEntity));
The contains() method checks if the two objects cls and valueEntity are present in the exact order in which they are mentioned and this fails if the order in the set is different from the order mentioned.
To fix this, contains() is replaced by hasItems() which does not check the order of items.
Code change-
assertThat(rootEntities, hasItems(cls, valueEntity));
Please let me know if you have any questions or need any additional justification/changes from my side.