Simplify next Fork boilerplate creation. #14761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
force-pushed
the
simplify-fork-creation
branch
9 times, most recently
from
dd3bfcb to
84b3b43
Compare
rkapka
reviewed
Jan 2, 2025
| } | ||
|
|
||
| return attr | ||
| log.WithField("version", st.Version()).Error("Could not get payload attribute due to unknown state version") |
There was a problem hiding this comment.
It is much more readable to use version.String() in logs
| } | ||
|
|
||
| err = errors.New("unknown state version") |
There was a problem hiding this comment.
Can you add the version field?
| }) | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("unknown execution block version for payload %d", bVersion) |
There was a problem hiding this comment.
Can you add version.String()?
There was a problem hiding this comment.
Done in Done in cb41166..
rkapka
reviewed
Jan 2, 2025
nalepae
force-pushed
the
simplify-fork-creation
branch
from
84b3b43 to
6a0f2aa
Compare
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
nalepae
force-pushed
the
simplify-fork-creation
branch
from
b140ec5 to
cb41166
Compare
nalepae
force-pushed
the
simplify-fork-creation
branch
from
cb41166 to
d2abad7
Compare
rkapka
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR aims to simplify the creation of the boilerplate for a new fork.
It uses
instead of
when possible.
The rationale is we assume, from fork
<n>to fork<n+1>, that changing items are less numerous than remaining ones.Using the
>approach instead of theswitch/caseone lets the developer not to add the new fork version as a specific case when not needed.This PR re-organises when possible functions by fork.
When adding the boilerplate for a new fork is needed, only the tail of the file needs to be modified.
Some types (example:
enginev1.ExecutionPayloadHeaderElectra) where aliased to the same type from previous forks (example:enginev1.ExecutionPayloadHeaderDeneb). This usage is quite exceptional in the codebase. In the vast majority of the code base, when a fork use a struct defined in a previous fork, then this struct is directly used.Aliased types are removed to keep the codebase consistent.
Other notes for review
This PR does not bring any functional change.
Acknowledgements