Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzer: add special-case for multi-line EOF TokenError #1991

Merged
merged 10 commits into from
Feb 20, 2021
Merged

fuzzer: add special-case for multi-line EOF TokenError #1991

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
054324f
Add special-case for multi-line EOF TokenError under Python3.7
jayaddison Feb 16, 2021
9aa18d9
Update conditional check to correspond to original issue description …
jayaddison Feb 17, 2021
4d38271
Add warning and hint regarding replaying the fuzzer code generation
jayaddison Feb 17, 2021
cf907a2
Include code review suggestion (with modifications for this to follow)
jayaddison Feb 18, 2021
be5c1e9
Remove Python version check, since this issue does exist across more …
jayaddison Feb 18, 2021
9a4faeb
Update explanatory comment
jayaddison Feb 18, 2021
357b7cc
Add clarification for potentially-ambiguous blib2to3 import
jayaddison Feb 18, 2021
ed702cf
Update explanatory comment
jayaddison Feb 18, 2021
a2c1a27
Bring comment into consistent format with previous comment
jayaddison Feb 18, 2021
8f0c90b
Revert "Add clarification for potentially-ambiguous blib2to3 import"
jayaddison Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions fuzz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@
a coverage-guided fuzzer I'm working on.
"""

import re

import hypothesmith
from hypothesis import HealthCheck, given, settings, strategies as st

import black
from blib2to3.pgen2.tokenize import TokenError


# This test uses the Hypothesis and Hypothesmith libraries to generate random
Expand Down Expand Up @@ -46,6 +49,16 @@ def test_idempotent_any_syntatically_valid_python(
# able to cope with it. See issues #970, #1012, #1358, and #1557.
# TODO: remove this try-except block when issues are resolved.
return
except TokenError as e:
if (
e.args[0] == "EOF in multi-line statement"
and re.search(r"\r?\n\\\r?\n", src_contents) is not None
):
# This is a bug - if it's valid Python code, as above, Black should be
# able to cope with it. See issue #1012.
# TODO: remove this block when the issue is resolved.
return
raise

# And check that we got equivalent and stable output.
black.assert_equivalent(src_contents, dst_contents)
Expand Down