Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we are currently updating views, there can be a huge overhead which is especially problematic in two scenarios
Two avoid such overheads, I am proposing the following changes
new_data
,i.e. reformat once after all scans and views have been loaded
Example benchmarks of data loading times before/after the above changes have been applied
Case 1
Electron Ptychography data with N frames of shape XxY
Data loading before: XX seconds
Data loading after: YY seconds
Speed increase Nx
Case 2
Ptychography data set with N scans, each with K frames of shape XxY, combined into a single reconstruction.
Data loading before: XX seconds
Data loading after: YY seconds
Speed increase Nx