Update framework metadata information. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `.pubnub.yml` file with change logs and distirbution options. build: Add '.pubnub.yml' validators Add GitH ub Actions for `.pubnub.yml` file validation.
crimsonred
reviewed
May 19, 2021
| source-repository: https://github.com/pubnub/eon-map | ||
| documentation: https://www.pubnub.com/developers/eon | ||
| distributions: | ||
| - distribution-type: source |
There was a problem hiding this comment.
Distribution type? Usually it is package, source
There was a problem hiding this comment.
Source is not there in the enum (and source is equivalent to api-client)
"api-client", "library", "package", "application", "framework"
There was a problem hiding this comment.
Where?
"distribution-type": {
"type": "string",
"description" : "The type of the distribution. e.g. package"
},There was a problem hiding this comment.
Please check artifact-type, I will double check if we need the same enum here as well
There was a problem hiding this comment.
But you left comment on distribution type (or GitHub app for phone is buggy)
There was a problem hiding this comment.
ya I mentioned it on distribution type, and it should use the same enums from artifact-type. (I will double check though)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '.pubnub.yml' file
Add
.pubnub.ymlfile with change logs and distirbution options.Add '.pubnub.yml' validators
Add GitHub Actions for
.pubnub.ymlfile validation.