Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows signing with freeDiskSpaceBeforeBuild #1216

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 12, 2024

Fixes #1215.

@danielrbradley
Copy link
Member

I would suggest, instead of using the login action, we should just not delete the AZ CLI that we need. This would give us the flexibility to move the signing to the makefile without needing to revert this.

The AZ CLI removal is part of the large-packages option in the action: https://github.com/jlumbroso/free-disk-space

The current disk space savings in AWS are:

=> Android library: Saved 7.6GiB
=> Haskell runtime: Saved 5.4GiB
=> Large misc. packages: Saved 6.3GiB
=> Docker images: Saved 2.5GiB
=> Overall 22GiB

This would therefore reduce to approximately 16GiB savings instead, which I think should suffice. Alternatively, we could just disable large packages on the build job only.

Of the 2 minutes spent saving disk space, 1m 44s is spent on the large packages, so disabling this option would also save a significant amount of time in each run. Which might make it feasible to turn back on for the xyz package too - to increase our test coverage.

@blampe
Copy link
Contributor Author

blampe commented Dec 12, 2024

I would suggest, instead of using the login action, we should just not delete the AZ CLI that we need. This would give us the flexibility to move the signing to the makefile without needing to revert this.

Yeah, I initially went that route but then figured 6GB was a bit too much to trade off. I'll go ahead and hook it up that way, the login action needs an additional secret anyway.

@blampe blampe requested a review from a team December 12, 2024 18:28
@blampe blampe added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 5918ee1 Dec 12, 2024
6 checks passed
@blampe blampe deleted the blampe/build-az branch December 12, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows signing breaks if freeDiskSpaceBeforeBuild: true is set
3 participants