Always spin up KinD cluster for pulumi-kubernetes-* providers in test step #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Reasonable to unbreak things.
Just so you're aware, we actually just consolidated the test workflow for bridged providers in #1214, which is nice because it prevents bugs like this.
In the future I'll be looking into moving this setup out of CI and into the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to create the KinD cluster in all workflows that run tests, not just the
run-acceptanceworkflow. For the pulumi-kubernetes provider, we don't need to create a KinD cluster as we create a GKE cluster for testing instead.Closes: pulumi/pulumi-kubernetes-cert-manager#254