Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Native: Add AWS credentials before Test Provider Library step #1239

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mikhailshilkov
Copy link
Member

In pulumi/pulumi-aws-native#1919 I want to run an actual end-2-end test with pulumitest in AWS Native, which requires AWS credentials. In understand that a larger consolidation may be coming with #1101, but this change would allow me to land my test ahead of that. Please let me know if there is a better way of achieving the same outcome.

@mikhailshilkov mikhailshilkov marked this pull request as draft December 19, 2024 14:10
@flostadler
Copy link
Contributor

I think this approach is fine as a stop-gap until native providers are on provider-ci as well! Code changes look good to me.

@mikhailshilkov mikhailshilkov marked this pull request as ready for review December 20, 2024 13:58
@mikhailshilkov mikhailshilkov added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit 720a1a8 Dec 20, 2024
9 checks passed
@mikhailshilkov mikhailshilkov deleted the mikhailshilkov/aws-native-aws-credentials branch December 20, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants