Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentinel job for native providers #1241

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 19, 2024

p-k has a weird bug pulumi/pulumi-kubernetes#3382 where we aren't able to depend on the correct "Sentinel" check.

This updates the native sentinel job to more closely match the bridged one:

sentinel:
name: sentinel
if: github.event_name == 'repository_dispatch' ||
github.event.pull_request.head.repo.full_name == github.repository
permissions:
statuses: write
needs:
- test
- build_provider
- license_check
runs-on: ubuntu-latest
steps:
- uses: guibranco/github-status-action-v2@0849440ec82c5fa69b2377725b9b7852a3977e76 # v1.1.13
with:
authToken: ${{secrets.GITHUB_TOKEN}}
# Write an explicit status check called "Sentinel" which will only pass if this code really runs.
# This should always be a required check for PRs.
context: 'Sentinel'
description: 'All required checks passed'
state: 'success'
# Write to the PR commit SHA if it's available as we don't want the merge commit sha,
# otherwise use the current SHA for any other type of build.
sha: ${{ github.event.pull_request.head.sha || github.sha }}

Other native providers don't have this problem, so I don't actually think this will resolve the issue, but it should at least help rule out any permission weirdness.

Edit: OK I ran this against p-k here pulumi/pulumi-kubernetes#3383 and suddenly the Sentinel check is available to us! So it does seem there's something wonky about the job's settings.

Before
image

After
image

@blampe blampe requested review from t0yv0 and rquitales December 19, 2024 21:18
@blampe blampe requested a review from a team December 19, 2024 22:16
@blampe blampe changed the title Update status sentinel for native providers Update sentinel job for native providers Dec 19, 2024
@blampe blampe enabled auto-merge December 19, 2024 22:17
@blampe blampe added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit b405e5a Dec 19, 2024
8 checks passed
@blampe blampe deleted the blampe/native-status branch December 19, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants