Regenerate Github Actions workflows for pulumi-acme #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
simenandre
previously approved these changes
Dec 10, 2024
|
@simenandre why approve if the linked run fails? The Pulumi team integrated signing their Windows binary, but we don't have that configured, so it fails for Pulumiverse builds. |
Why should I review if a run fails? |
ringods
force-pushed
the
chore/resync-12248868650
branch
from
990636a to
e86a916
Compare
ringods
force-pushed
the
chore/resync-12248868650
branch
from
e86a916 to
16ad22e
Compare
|
@simenandre as far as I know, I did not request for a review. My last commit fixes the workflows again and I submitted a fix upstream. So this PR is good for review (and approval 😄 ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was generated automatically by the resync-build workflow in this repository.