Regenerate Github Actions workflows for pulumi-acme #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
ringods
force-pushed
the
chore/resync-12365785744
branch
from
df34c7b to
a14783c
Compare
github-merge-queue bot
pushed a commit
to pulumi/ci-mgmt
that referenced
this pull request
Dec 17, 2024
The `permissions` block in a reusable workflow doesn't grant these permissions. These are more used as an early indication of the permissions required by the reusable workflow. The correct permissions still need to be set on the calling side. See `Reusable workflows` in [this blog article](https://www.kenmuse.com/blog/github-actions-workflow-permissions/). Follow up to #1214. Without setting the `permissions` on the calling side, the reusable workflow will not have the correct permissions. The Pulumiverse runs failed without the required `permissions` block: https://github.com/pulumiverse/pulumi-acme/actions/runs/12365788538 After adding the `permissions` block on the calling side: https://github.com/pulumiverse/pulumi-acme/actions/runs/12369028130 pulumiverse/pulumi-acme#98 For Pulumiverse, this fails because the organization wide workflow settings are configured to `Read repository contents and packages permissions`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was generated automatically by the resync-build workflow in this repository.