-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline startup #612
Open
zardus
wants to merge
6
commits into
master
Choose a base branch
from
wip/dojo-init
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Streamline startup #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zardus
force-pushed
the
wip/dojo-init
branch
2 times, most recently
from
October 27, 2024 08:18
b798a57
to
a6befbe
Compare
Failing with:
|
zardus
force-pushed
the
wip/dojo-init
branch
2 times, most recently
from
October 27, 2024 09:45
e830493
to
82a8ef6
Compare
This is fucked. |
zardus
changed the title
Streamline startup and document architecture
Streamline startup
Oct 27, 2024
spencerpogo
reviewed
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing ARCHITECTURE.md, I realized that the way we start the dojo is very convoluted (docker calls
dojo init
which callsdojo-init
and then starts systemd, which in turn callsdojo up
. I changed the startup flow to:dojo-init.service
that callsdojo-init
.dojo-up.service
that callsdojo-up
.This makes things more sane, and also turns us into a two-stop-shop for the most important logs (
journalctl
for-u dojo-init
and-u dojo-up
anddocker logs ctfd
for ctfd logs).