Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sei composite multiparticle #4693

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

sei; no porosity

83264a1
Select commit
Loading
Failed to load commit list.
Draft

Sei composite multiparticle #4693

sei; no porosity
83264a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 18, 2024 in 1s

99.08% (-0.14%) compared to 864388f

View this Pull Request on Codecov

99.08% (-0.14%) compared to 864388f

Details

Codecov Report

Attention: Patch coverage is 79.47020% with 31 lines in your changes missing coverage. Please review.

Project coverage is 99.08%. Comparing base (864388f) to head (83264a1).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
.../pybamm/parameters/size_distribution_parameters.py 38.09% 13 Missing ⚠️
src/pybamm/expression_tree/averages.py 63.15% 7 Missing ⚠️
.../submodels/active_material/base_active_material.py 60.00% 4 Missing ⚠️
src/pybamm/geometry/battery_geometry.py 66.66% 2 Missing ⚠️
src/pybamm/parameters/geometric_parameters.py 71.42% 2 Missing ⚠️
...ybamm/models/submodels/interface/base_interface.py 93.33% 1 Missing ⚠️
...s/submodels/interface/total_interfacial_current.py 75.00% 1 Missing ⚠️
.../pybamm/models/submodels/porosity/base_porosity.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4693      +/-   ##
===========================================
- Coverage    99.21%   99.08%   -0.14%     
===========================================
  Files          302      302              
  Lines        22880    22996     +116     
===========================================
+ Hits         22701    22786      +85     
- Misses         179      210      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov