update github action

[samwaseda]

No description provided.

[github-actions]

👈 Launch a binder notebook on branch pyiron/uniton/update_actions

[mbruns91]

After some issues with my release (sorry, but I think it's ok now) another issue occurs https://github.com/pyiron/uniton/actions/runs/11348195667/job/31561387155

It seems that the newest ubuntu-runner (??? at least that's my impression) doesn't allow pip to be run casually to protect system-python.

so (as suggested in the error output) in the original write_docs.yml action it should be changed
pip install pyyaml -> apt install python3-yaml (I checked the name of the correct package on launchpad.net).

@liamhuber, what do you think?

[liamhuber]

After some issues with my release (sorry, but I think it's ok now)

🚀

another issue occurs https://github.com/pyiron/uniton/actions/runs/11348195667/job/31561387155

It seems that the newest ubuntu-runner (??? at least that's my impression) doesn't allow pip to be run casually to protect system-python.

Can we confirm this? This can be tested by modifying the runner explicitly in the workflow to be an older image.

I found it via google, no need to confirm: actions/runner-images#10781

so (as suggested in the error output) in the original write_docs.yml action it should be changed pip install pyyaml -> apt install python3-yaml (I checked the name of the correct package on launchpad.net).

@liamhuber, what do you think?

IMO this is a problem with the image, not a problem with the workflow. In practice we only run this workflow on ubuntu, but in principle this is not specified in the action itself which specifies a using: "composite". Switching from pip to apt would make the action unusable on windows, yeah?

A better solution would be to manually specify the runner input. Thankfully, this is easily exposed in the reusable workflows we're leveraging. Please try specifying the runner input as "ubuntu-22.04" to override the default of "ubuntu-latest".

The downside is that we'll need to do this in each downstream repo, the upside is that there's nothing intrinsically wrong with specifying a particular runner, and we don't wind up messing around with our infrastructure just to accommodate the fact someone made a mistake upstream. I strongly prefer the verbosity over making an unnecessary structural change.

[mbruns91]

Ok, so for this repo, I totally agree with you, @liamhuber. For the actions in gerneral I think it is worth to consider to go another route. But it's a better idea - I guess - to have this conversation here.

To wrap this one up here (@samwaseda: I can do this tomorrow):

• go back to [email protected]
• specify the runner runner: "ubuntu-22.04"

[liamhuber]

go back to [email protected]

[email protected]

@v3.3.2 will target the (mutable) branch rather than the release (an immutable tagged commit). In this case, we control the actions repo so realistically there is no security concern, but in principle we want the immutable one for safety.

[mbruns91]

I don't know if it's an issue on my side, but I can't push to this repo.
(I just tested to push something to another repo of the pyiron organization and it works fine.)

[samwaseda]

now?

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.42% (target: -1.00%)	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (781bfb0)	64	62	96.88%
Head commit (9ba255f)	74 (+10)	72 (+10)	97.30% (+0.42%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#11)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[mbruns91]

preview-release.yml uses pyiron/actions/.github/workflows/[email protected], which doesn't expose the selection of a specific runner. I out-commented the respective line.

I think we should fix this upstream in pyiron/actions, i.e. exposing runner as optinal input in pyiron/actions/.github/workflows/pyproject-release.yml

[liamhuber]

Super, glad to see this fix worked as expected. @mbruns91, I totally agree the other workflow should also expose the runner as an argument.

[coveralls]

Pull Request Test Coverage Report for Build 11400689592

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.297%

---

Totals
Change from base Build 11375358989:	0.0%
Covered Lines:	72
Relevant Lines:	74

---

💛 - Coveralls