-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyodide, system installs. #2675
Conversation
…s for use with swig. Controlled with new arg `infer_swig_includes`, default is true. This is a bit crude, but is necessary if we are to allow things to be specified with just CFLAGS and not a dedicated INCLUDES or setting of `includes` parameter.
Removed use of `PYMUPDF_MUPDF_INCLUDE` as not required. Pyodide builds are now indicated by OS='pyodide', not `wasm`; this follows MuPDF.
…ide builds. This matches recent change to MuPDF.
docs/installation.rst
Outdated
@@ -84,41 +82,66 @@ There are no **mandatory** external dependencies. However, some optional feature | |||
.. note:: You can install these additional components at any time -- before or after installing PyMuPDF. PyMuPDF will detect their presence during import or when the respective functions are being used. | |||
|
|||
|
|||
Installation from source without using an sdist | |||
Build and install from local PyMuPDF checkout and optional local MuPDF checkout. | |||
--------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This underline needs to go all the way over the parent text otherwise it won't render correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant "under the parent text" .....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it seems to work: https://ghostscript.com/~julian/docs-PyMuPDF/installation.html
But i'll fix it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha - perhaps this was something that was just broken with a previous theme !
docs/installation.rst
Outdated
|
||
git clone https://github.com/pymupdf/PyMuPDF.git | ||
git clone https://github.com/pymupdf/PyMuPDF.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
docs/installation.rst
Outdated
|
||
* Build and install PyMuPDF:: | ||
* Build and install PyMuPDF: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ::
denotes that the tab indented stuff appears as <code>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i was trying to avoid this, but it doesn't work, so have fixed to use ::
.
git clone --recursive https://ghostscript.com:/home/git/mupdf.git | ||
|
||
* | ||
Build PyMuPDF, specifying the location of the local MuPDF tree with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the text should start after the *
bullet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sometimes do it this way so i can easily word-wrap the text. It does look less good as plain text, but realistically i suspect no one actually reads docs by looking at the plain markup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough
docs/installation.rst
Outdated
|
||
Building for different Python versions in same PyMuPDF tree: | ||
|
||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the text should start after the *
bullet.
65c8dcd
to
fe43665
Compare
We now run `apt update` first.
We specify pyodide-build==0.23.4.
fe43665
to
738aa77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.