Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose PEP 740 attestations functionality #236
Expose PEP 740 attestations functionality #236
Changes from 34 commits
b526ff8
f267787
1571a0d
27500cf
e9c72dd
3166978
e7bd6ea
5aa7e41
4bc4ced
0e2b9c9
242d7e9
aa69903
6b4d371
16aa3a2
6dbccb5
16b5dc1
251402e
1e91a3b
835d65d
95be6b9
176c905
9bac976
6a808bf
1bb6510
8c640e3
e6556ab
8094cdf
57dba07
af78f7a
bcc935f
66f02b6
28806ba
fed8784
61ffce1
e1b63c3
15d9377
473ca48
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the bug snuck in that needed fixing by 0ab0b79.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 thanks for fixing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary given pypa/twine#1099?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary, since
twine
will catch this case and produce an appropriate error. OTOH catching it here might make the error slightly more intelligible, since thetwine
error doesn't get propagated into a::warning
annotation like this one does.This is similar to how the action pre-validates the dist directory, even though
twine
also validates it. But if you think it makes it makes things more confusing than necessary, I can drop this check 🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably fine for this to catch it before twine and give a more tailored error message, I'm mostly just thinking about the long-term pain of maintaining/updating this list of supported indexes in multiple places, but this is fine for now.