Completely remove click echo #6324
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
force-pushed
the
completely-remove-click-echo
branch
4 times, most recently
from
275af4b to
d952ceb
Compare
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Extracting value from dictionary without calling `.items()` Even though we're using `keys` ruff complains ... Signed-off-by: Oz Tiram <[email protected]>
This version supports modern python versions Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
These were breaking on python3.8 which is now EOL. Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
rich respects the NO_COLOR environment variable. Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
We never really made any usage of click's `ClickException.show()`. Hence, it is ok to just get read of the ClickException base class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work to get rid of click.echo ...