-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make django_settings_is_configured return the first value always #708
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 98.03% 98.03% +<.01%
==========================================
Files 32 32
Lines 1831 1836 +5
Branches 142 142
==========================================
+ Hits 1795 1800 +5
Misses 23 23
Partials 13 13
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=========================================
- Coverage 98.1% 98.01% -0.1%
=========================================
Files 32 32
Lines 1902 1861 -41
Branches 149 149
=========================================
- Hits 1866 1824 -42
Misses 23 23
- Partials 13 14 +1
Continue to review full report at Codecov.
|
0e879ae
to
3361768
Compare
I have been seeing an issue, where it would return False initially, but later True; causing an `AttributeError` with the `mailoutbox` fixture, because `mail.outbox` was not set on the module. This can happen with imported code that changes the environment, e.g. via "wsgi/asgi.py": > os.environ.setdefault("DJANGO_SETTINGS_MODULE", "foo.settings")
3361768
to
74e310a
Compare
I have been seeing an issue, where it would return False initially, but
later True; causing an
AttributeError
with themailoutbox
fixture,because
mail.outbox
was not set on the module.This can happen with imported code that changes the environment, e.g.
via "wsgi/asgi.py":
TODO: