Skip to content

Commit

Permalink
Fix remove_class when methods have decorators
Browse files Browse the repository at this point in the history
  • Loading branch information
Code0x58 committed Nov 30, 2020
1 parent 39cdfaa commit 0a418c8
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 15 deletions.
13 changes: 13 additions & 0 deletions tests/fixtures/remove_class/dedent_in.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
class TestAssertNotEqual(TestCase):

def test_you(self):
pass


@property
def test_me(self):
[
item
for item in sequence
if item
]
12 changes: 12 additions & 0 deletions tests/fixtures/remove_class/dedent_out.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

def test_you(self):
pass


@property
def test_me(self):
[
item
for item in sequence
if item
]
50 changes: 35 additions & 15 deletions unittest2pytest/fixes/fix_remove_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,40 @@
Leaf(6, '')])])
"""

def safe_dedent(s, dedent):
"""
Dedent the prefix of a dedent token at the start of a line.
Non-syntactically meaningful newlines before tokens are appended to the prefix
of the following token, so this avoids removing the newline part of the prefix
when the token dedents to below the given level of indentation.
"""
for i, c in enumerate(s):
if c not in "\r\n":
break
else:
i = len(s)
return s[:i] + s[i:-dedent]

def dedent_suite(suite, dedent):
"""Dedent a suite in-place."""
leaves = suite.leaves()
for leaf in leaves:
if leaf.type == token.NEWLINE:
leaf = next(leaves, None)
if leaf is None:
return
if leaf.type == token.INDENT:
leaf.value = leaf.value[:-dedent]
else:
# this prefix will start with any duplicate newlines
leaf.prefix = safe_dedent(leaf.prefix, dedent)
elif leaf.type == token.INDENT:
leaf.value = leaf.value[:-dedent]
elif leaf.prefix[:1] in "\r\n":
leaf.prefix = leaf.prefix[:-dedent]

class FixRemoveClass(BaseFix):

PATTERN = """
Expand All @@ -56,25 +90,11 @@ class FixRemoveClass(BaseFix):
>
"""

def dedent(self, suite, dedent):
self.line_num = suite.get_lineno()
for kid in suite.leaves():
if kid.type in (token.INDENT, token.DEDENT):
self.line_num = kid.get_lineno()
# todo: handle tabs
kid.value = kid.value[dedent:]
self.current_indent = kid.value
elif kid.get_lineno() != self.line_num:
# todo: handle tabs
if len(kid.prefix) > len(self.current_indent):
kid.prefix = self.current_indent


def transform(self, node, results):
suite = results['suite'].clone()
# todo: handle tabs
dedent = len(find_indentation(suite)) - len(find_indentation(node))
self.dedent(suite, dedent)
dedent_suite(suite, dedent)

# remove the first newline behind the classdef header
first = suite.children[0]
Expand Down

0 comments on commit 0a418c8

Please sign in to comment.