Skip to content
This repository has been archived by the owner on Nov 2, 2022. It is now read-only.

Add docstring for split function and catch function, also try to make ExceptionGroup can work for now :) #3

Merged
merged 7 commits into from
Jan 22, 2019

Conversation

WindSoilder
Copy link
Contributor

Hope this can help to solve #1

@WindSoilder WindSoilder requested a review from njsmith January 18, 2019 11:26
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@91a286f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   56.97%           
=========================================
  Files             ?       10           
  Lines             ?      251           
  Branches          ?       27           
=========================================
  Hits              ?      143           
  Misses            ?      103           
  Partials          ?        5
Impacted Files Coverage Δ
exceptiongroup/_tools.py 56.06% <100%> (ø)
exceptiongroup/_tests/test_tools.py 100% <100%> (ø)
exceptiongroup/__init__.py 80.95% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a286f...eef4d66. Read the comment docs.

Copy link
Member

@njsmith njsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, thank you so much for picking this up! I have been feeling guilty about it for months :-).

A few comments, but really this is already an improvement; if you want to merge and then address them in a followup PR feel free.

exceptiongroup/_tests/test_tools.py Show resolved Hide resolved
exceptiongroup/__init__.py Show resolved Hide resolved
@WindSoilder
Copy link
Contributor Author

Very thanks for your encouragement and comments :) I have resolved them, please check and have a look.

@njsmith njsmith merged commit 6a0a18b into python-trio:master Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants