Skip to content

Commit

Permalink
Bump Codecov action to v5
Browse files Browse the repository at this point in the history
It's more stable and requires a token that is already in the config.

Alpine needs Git because of a bug in codecov-action [[1]].

[1]: codecov/codecov-action#1320
  • Loading branch information
webknjaz committed Dec 20, 2024
1 parent 0f270f9 commit 475843d
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
LSP: '${{ matrix.lsp }}'
LSP_EXTRACT_FILE: '${{ matrix.lsp_extract_file }}'
- if: always()
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: Windows (${{ matrix.python }}, ${{ matrix.arch }}${{ matrix.extra_name }})
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
- if: >-
always()
&& matrix.check_formatting != '1'
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
- name: Run tests
run: ./ci.sh
- if: always()
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: macOS (${{ matrix.python }})
Expand All @@ -191,9 +191,10 @@ jobs:
- name: Install necessary packages
# can't use setup-python because that python doesn't seem to work;
# `python3-dev` (rather than `python:alpine`) for some ctypes reason,
# `git` for codecov-action v4/v5 to work (https://github.com/codecov/codecov-action/issues/1320).
# `nodejs` for pyright (`node-env` pulls in nodejs but that takes a while and can time out the test).
# `perl` for a platform independent `sed -i` alternative
run: apk update && apk add python3-dev bash nodejs perl
run: apk update && apk add python3-dev bash git nodejs perl
- name: Enter virtual environment
run: python -m venv .venv
- name: Run tests
Expand All @@ -202,7 +203,7 @@ jobs:
id: get-version
run: echo "version=$(python -V | cut -d' ' -f2 | cut -d'.' -f1,2)" >> "${GITHUB_OUTPUT}"
- if: always()
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: Alpine
Expand Down

0 comments on commit 475843d

Please sign in to comment.