Add Task.eventual_parent_nursery introspection attribute #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 110 110
Lines 13466 13481 +15
Branches 1024 1025 +1
=======================================
+ Hits 13423 13438 +15
Misses 28 28
Partials 15 15
|
njsmith
reviewed
May 27, 2020
trio/_core/_run.py
Outdated
|
|
||
| If this task has already called ``started()``, or if it was not | ||
| spawned using `nursery.start() <trio.Nursery.start>`, then | ||
| `eventual_parent_nursery` is the same as `parent_nursery`. |
There was a problem hiding this comment.
I think I have a mild preference for "if the task isn't in the middle of start shenanigans, then eventual_parent_nursery is None". What do you think?
There was a problem hiding this comment.
I'm indifferent between the two so will change it to suit your preference!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks the nursery in which the task is going to run, even if it's not really running there yet because the
start()that spawned it hasn't returned. Came up in discussion surrounding #1523 but seems independently useful.