Add comment and assertion to pidfd_open
workaround
#2799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: assumptions were wrong
Ended up researching this during discussion in #2792, and thought I might as well add a comment (and an assertion to double-check assumptions). Also cleared up a coverage miss for an error that shouldn't trigger in test runs.
One could possibly raise a warning instead of the assertion to be extra defensive, but afaict it really shouldn't trigger on 3.9+ so the assertion+message is already very defensive IMO.
https://docs.python.org/3/library/os.html#os.pidfd_open