-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reason for failed match to RaisesGroup #3145
Draft
jakkdl
wants to merge
10
commits into
python-trio:main
Choose a base branch
from
jakkdl:raisesgroup_fail_reason
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
03a3959
RaisesGroup will now raise an assertionerror with an informative mess…
jakkdl c0dcb58
suggest allow_unwrapped if it would match with it
jakkdl 2b98b2f
fix test fails
jakkdl f84d9d1
codecov and fix suggestion to re.escape string
jakkdl df27595
add _check_expected helper
jakkdl 993a173
remove trailing period. Add trying_flattening and suggest_flattening.…
jakkdl 656e040
simplify & remove false positive for suggestion to use flatten_subgroups
jakkdl debe557
overhaul message in the complicated case. Avoid printing check repr i…
jakkdl a8e263c
Merge remote-tracking branch 'origin/main' into raisesgroup_fail_reason
jakkdl 8281d7c
Merge branch 'main' into raisesgroup_fail_reason
jakkdl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't classes that use
__slots__
define members before__init__
as well? It's just that they wouldn't have any values.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ye I suppose
__slots__
can also make this test work. Pytest seems to only use it sparingly though so don't think I will bother.