Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100384: Error on unguarded-availability in Darwin builds #128155

Merged
merged 6 commits into from
Dec 22, 2024
+51 −0
Merged

gh-100384: Error on unguarded-availability in Darwin builds #128155

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6fd3184
Error on `unguarded-availability-new` in Darwin builds
zanieb Dec 20, 2024
0f4b63e
Set `MACOSX_DEPLOYMENT_TARGET=10.9` in CI
zanieb Dec 21, 2024
2ddda3a
Use `-Werror=unguarded-availability` instead of `unguarded-availabili…
zanieb Dec 22, 2024
24ee4a7
Bump macOS deployment target to 10.13 in CI
zanieb Dec 22, 2024
88ea223
Update news blurb
zanieb Dec 22, 2024
dcbd9a6
Bump `MACOSX_DEPLOYMENT_TARGET` to 10.15
zanieb Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/reusable-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
brew link --overwrite tcl-tk@8
- name: Configure CPython
run: |
MACOSX_DEPLOYMENT_TARGET=10.9 \
GDBM_CFLAGS="-I$(brew --prefix gdbm)/include" \
GDBM_LIBS="-L$(brew --prefix gdbm)/lib -lgdbm" \
./configure \
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2024-12-21-09-56-37.gh-issue-100384.Ib-XrN.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Error on ``unguarded-availability-new`` in Darwin builds, preventing invalid
Copy link
Member

@ned-deily ned-deily Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unguarded-availability-new -> unguarded-availability
Darwin -> macOS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 88ea223

use of symbols that are not available in older versions of the OS.
41 changes: 41 additions & 0 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2603,6 +2603,13 @@ AS_VAR_IF([ac_cv_gcc_compat], [yes], [
esac
AC_MSG_RESULT([$CC])
# Error on unguarded use of new symbols, which will fail at runtime for
# users on older versions of macOS
AX_CHECK_COMPILE_FLAG([-Wunguarded-availability-new],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted elsewhere, I think we should use unguarded-availability here, not -new but I want to test this on older systems which I won't be able to do for several more days.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 2ddda3a. This did not change the output on my machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or in CI)

[AS_VAR_APPEND([CFLAGS_NODIST], [" -Werror=unguarded-availability-new"])],
[],
[-Werror])
LIPO_INTEL64_FLAGS=""
if test "${enable_universalsdk}"
then
Expand Down
Loading