-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found #5240
bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found #5240
Conversation
…SND chunk is not found Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError.
Please add your name in Misc/ACKS and add "Patch by your name." in the news file. |
@serhiy-storchaka: Please replace |
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
…SND chunk is not found (pythonGH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
GH-5780 is a backport of this pull request to the 3.7 branch. |
…SND chunk is not found (pythonGH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
GH-5781 is a backport of this pull request to the 2.7 branch. |
…SND chunk is not found (pythonGH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
GH-5782 is a backport of this pull request to the 3.6 branch. |
…SND chunk is not found (GH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
…SND chunk is not found (GH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
… the SSND chunk is not found (GH-5240) (GH-5781) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
Thank you @serhiy-storchaka. |
Initialize self._ssnd_chunk so that aifc.Error is raised as intended,
not AttributeError.
This mirrors what is done in Wave_read.initfp() for self._data_chunk.
https://bugs.python.org/issue31848