Fix todo in pycocotools #13182
Open
Fix todo in pycocotools #13182
+32
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds numpy types. All the types were already there as comments.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@hoel-bagard please take a look and @AlexWaygood since you approved the previous request in pycocotools |
This comment has been minimized.
This comment has been minimized.
hoel-bagard
reviewed
Dec 4, 2024
hoel-bagard
reviewed
Dec 4, 2024
|
|
||
| _NDArray: TypeAlias = Incomplete | ||
| _NDArray: TypeAlias = npt.NDArray[np.float64] |
There was a problem hiding this comment.
It might be better to rename this to _NDFloatArray or something similar ?
This comment has been minimized.
This comment has been minimized.
sobolevn
reviewed
Dec 4, 2024
Using semi-colon is important here.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@hoel-bagard @AlexWaygood friendly ping for a second round of reviews, please. |
hoel-bagard
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds numpy types.
All the types were already there as comments.