Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify runtime implementation of Generic #1876

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clarify runtime implementation of Generic #1876

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb3e35
Clarify runtime implementation of `Generic`
Viicos Oct 29, 2024
9a91ed0
fixup
Viicos Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/spec/generics.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ should treat the two largely equivalently (except for variance, see below).
takes a single type parameter ``T``. This also makes ``T`` valid as
a type within the class body.

The ``Generic`` base class uses a metaclass that defines ``__getitem__``
so that ``LoggedVar[t]`` is valid as a type::
The ``Generic`` base class implements the :func:`~object.__class_getitem__`
classmethod so that ``LoggedVar[t]`` is valid as a type::

from collections.abc import Iterable

Expand Down