내 티켓 정보 출력 버그 수정 #248
Merged
내 티켓 정보 출력 버그 수정 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-nicelee
force-pushed
the
fix/my-ticket-information
branch
from
c42af9a to
123a955
Compare
향후 옵션이 추가될 경우(ex: 아이돌봄) 리팩토링 해야함 REF: #247 Signed-off-by: cmygray <[email protected]>
REF: #247 Signed-off-by: cmygray <[email protected]>
cmygray
reviewed
Jul 16, 2019
| const {id, status, amount, paidAt, options, product, receiptUrl, cancelReceiptUrl} = ticket | ||
| const {type, nameKo, nameEn, descKo, descEn, cancelableDate, startAt, finishAt} = product | ||
| const {type, name, desc, cancelableDate, startAt, finishAt} = product | ||
| const parsedOptions = JSON.parse(options) |
There was a problem hiding this comment.
options === '"{}"' 인 경우가 발생하는 것 같습니다. 그래서 파싱했을 때 { 0: '{', 1: '}' } 이 되는..
@amazingguni Ticket.options 필드의 기본값이 dict 로 되어있는데요, "{}" 로 serialize 되면 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내 티켓 정보 출력 버그 수정