This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
modularize words prediction #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A series of diffs to extend words prediction so that it can be used as vocab reduction purpose on any arch. The code under research/words_prediction has lots of reduandant logic, both in the loss and model arch. This diff tries to make words prediction a plug and play which can work with existing translation loss and encoder/decoder classes. Reviewed By: jhcross Differential Revision: D9012503 fbshipit-source-id: 775c265e5fadebb78c9b933f7131485ae8239c09
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A series of diffs to extend words prediction so
that it can be used as vocab reduction purpose on any arch.
The code under research/words_prediction has lots of reduandant logic, both in
the loss and model arch. This diff tries to make words prediction a plug and
play which can work with existing translation loss and encoder/decoder classes.
Reviewed By: jhcross
Differential Revision: D9012503