This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Fix dimension off by not adding things to dictionary in intermediate eval #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eval (pytorch#573) Summary: Pull Request resolved: pytorch#573 Repeat title. The long term solution could be to add an option to distinguish intermediate eval. But confirmed with Juan setting it to False shouldn't affect existing stuff. Reviewed By: jmp84 Differential Revision: D15793470 fbshipit-source-id: 670de05741607e6765cb8f839cab1301999ba1f0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Repeat title. The long term solution could be to add an option to distinguish intermediate eval. But confirmed with Juan setting it to False shouldn't affect existing stuff.
Differential Revision: D15793470