Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin structure requirements for upload to directory #9303

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

ioalexei
Copy link
Contributor

Fixes #9192 :

  • add reference to required LICENSE file

Goal: clarify required files for validation in the official plugin repository

Ticket(s): #9192

  • Backport to LTR documentation is requested

@DelazJ
Copy link
Collaborator

DelazJ commented Oct 14, 2024

@Xpirix may I request your feedback here please? Thanks.

@Xpirix
Copy link

Xpirix commented Oct 15, 2024

Thanks for this change @ioalexei and @DelazJ. This reflects the current plugin upload requirements and will likely help authors successfully upload their plugins. Is it possible to mention that the requirement is valid for both new plugins and new versions of existing plugins?

In the future, the LICENSE requirement may change depending on the discussion at qgis/QGIS-Django#453, but I think this looks good for now.

Copy link
Contributor

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ioalexei
It's not the topic in this PR, but I would also remove the resources file. It's mostly not used anymore and I do not recommend it (and also L136, 137)

docs/pyqgis_developer_cookbook/plugins/releasing.rst Outdated Show resolved Hide resolved
ioalexei and others added 4 commits October 15, 2024 08:17
@ioalexei
Copy link
Contributor Author

  • Merged suggestions from @DelazJ and @Gustry
  • Fixed a typo
  • Added clarification that it applies to updates as well as newly published plugins
  • Mentioned the license requirement in the plugin structure setting as well

@DelazJ DelazJ enabled auto-merge (squash) October 15, 2024 16:26
@DelazJ DelazJ merged commit cfcbdd2 into qgis:master Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement for LICENSE file when updating plugin is not documented
4 participants