-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GroundStateProjection operator for FockSpace #229
base: master
Are you sure you want to change the base?
Conversation
if you have an opinion on where to best add it to the documentation, let me know. |
also maybe it would be nice to use the same symbol as for the destroyer and make the print symbol something like ∅ₐ if the symbol is a |
Hi @benneti ! Thanks for contributing here. I had a brief look at the code and everything looks completely fine. However, I'm afraid I have to raise a conceptual issue here, which I'm not entirely certain on myself. In this PR you're implementing the Fock ground state projector
Is that correct? The issue that I'm talking about arises when you consider products such as (I'm picking a simple example here) You'd need to check that for some example. That actually brings me to another question: while I'm sure there are applications for this out there, I don't really know one off the top of my head. Since you're implementing this, I'm sure you have a specific problem you'd like to solve in mind. Could you share that? Or better yet a reduced example? That would allow us to see if the current implementation makes sense. After all, what matters is whether the produced Physics is correct. Also, one more note: if you're now thinking you could implement the simplification I mention and generally implement a projection operator of the for |
Thank you, to be honest this is a fair point; I never intend to use this for a cumulant expansion but as a convenient way to calculate some linear optics expectation values using the commutation algebra you have already implemented. |
also yes the properties of the GS Projection are correct |
Ah I see. Well that context was lost on me of course. No need to split things as this is a clean addition and doesn't affect anything else. It would probably be good to point out this issue in the documentation as it will "just work" with the cumulant expansion. |
Yeah sorry, I did not think of adding some context to the PR. Added a warning to the docstring and squashed the commits! |
But I think the latexify logic is not right yet. EDIT: nevermind works now |
this PR extends the Fockspace definition to include a ground state projection operator.