Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing istree method for QTerm types #96

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Conversation

david-pl
Copy link
Member

@david-pl david-pl commented Jan 1, 2022

We were missing the istree(::Type{<:QTerm})=true method, so similarterm returned the wrong thing. This lead to errors in substitute (see also #93).

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #96 (5b93aaa) into master (aa5cfa9) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   83.40%   83.24%   -0.17%     
==========================================
  Files          16       16              
  Lines        1742     1743       +1     
==========================================
- Hits         1453     1451       -2     
- Misses        289      292       +3     
Impacted Files Coverage Δ
src/qnumber.jl 90.23% <100.00%> (+0.98%) ⬆️
src/correlation.jl 85.71% <0.00%> (-1.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa5cfa9...5b93aaa. Read the comment docs.

@david-pl david-pl merged commit fdcfe8a into master Jan 1, 2022
@david-pl david-pl deleted the fix-substitute branch January 1, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant