Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Should not purify 'bg-*' and 'text-*' classes #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastienroul
Copy link

@sebastienroul sebastienroul commented Oct 8, 2017

Using variables in some ways to set the color (or bg-color) is not reconized by purifycss even if they try to thing the more crazy things [https://github.com/purifycss/purifycss#detecting-the-use-of-button-active-1]
So, always adding colors in the final packaging could be great for dev more crazy than puryfyccss's team :o) or people using color as functional feature....

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Using variables in some ways to set the color (or bg-color) is not reconized by `purifycss` even if they try to thing the more crazy things [https://github.com/purifycss/purifycss#detecting-the-use-of-button-active-1]
So, always adding colors in the final packaging could be great for dev more crazy than puryfyccss's team :o) or people using color as functional feature....
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant