client: fix panic on request failure

Fixes the worst of #1186 Backports: #1188 Signed-off-by: Hank Donnay <[email protected]>
quay · Feb 17, 2021 · 8b63953 · 8b63953
1 parent 8a392f1
commit 8b63953
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/httptransport/client/indexer.go b/httptransport/client/indexer.go
@@ -42,6 +42,10 @@ func (s *HTTP) AffectedManifests(ctx context.Context, v []claircore.Vulnerabilit
 		defer resp.Body.Close()
 	}
 	if err != nil {
+		return affected, fmt.Errorf("request failed: %v", err)
+	}
+	defer resp.Body.Close()
+	if resp.StatusCode != http.StatusOK {
 		return affected, &clairerror.ErrRequestFail{Code: resp.StatusCode, Status: resp.Status}
 	}
 	err = json.NewDecoder(resp.Body).Decode(&affected)