Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httptransort: fix http metrics #1985

Merged
merged 3 commits into from
Feb 19, 2024
Merged

httptransort: fix http metrics #1985

merged 3 commits into from
Feb 19, 2024

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Feb 19, 2024

The runtime.Goexit usage messes with the prometheus metrics, so this inserts a handler to catch unwinds using the documented http.ErrAbortHandler.

@hdonnay hdonnay requested a review from a team as a code owner February 19, 2024 22:20
@hdonnay hdonnay requested review from crozzy and removed request for a team February 19, 2024 22:20
crozzy
crozzy approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hdonnay hdonnay merged commit e84883f into quay:main Feb 19, 2024
8 checks passed
@hdonnay hdonnay deleted the bug/http-metrics branch February 19, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crozzy crozzy crozzy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdonnay @crozzy