-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Collection Aggregations #688
Draft
gwaramadze
wants to merge
22
commits into
main
Choose a base branch
from
feature/collections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwaramadze
force-pushed
the
feature/collections
branch
2 times, most recently
from
December 18, 2024 09:19
c2d0410
to
f49ac74
Compare
gwaramadze
force-pushed
the
feature/collections
branch
from
January 6, 2025 13:26
b6c8404
to
0be11dd
Compare
This is dictated by the legacy structure of the code. Method `delete` requires prefix and remainder of a key to be passed separately and refactoring this is a larger effort.
The helper method `_get_items` is more in line with a native rocksdict behavior where the lower band is inclusive and the upper exclusive. The inverted characteristics known from an upper scope's `get_windows` method are guaranteed by key deserialization and condition: `start_from_ms < start <= start_to_ms`. In the future, we should refactor the code to remove this condition and rely on `_get_items` inclusivity/exclusivity characteristics.
It is a shortcut to empty results if the given start timestamp is higher than the end timestamp. There are currently use cases in the code that may lead to this and there is no easy way to avoid it. The shortcut is required to avoid unexpected behaviors with negative integers converted to int64 encoded bytes.
gwaramadze
force-pushed
the
feature/collections
branch
from
January 6, 2025 15:37
ef1f5f8
to
5da6b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP