Skip to content

Fix a link and shorten a name. #1493

Fix a link and shorten a name.

Fix a link and shorten a name. #1493

Triggered via push January 1, 2025 13:43
Status Success
Total duration 2m 23s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
manual implementation of `Option::map`: src/importers/icalendar.rs#L220
warning: manual implementation of `Option::map` --> src/importers/icalendar.rs:220:12 | 220 | } else if let Some(attendee) = event | ____________^ 221 | | .multi_properties() 222 | | .get("ATTENDEE") 223 | | .and_then(|attendees| attendees.first()) ... | 227 | | None 228 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default help: try | 220 ~ } else { event 221 + .multi_properties() 222 + .get("ATTENDEE") 223 ~ .and_then(|attendees| attendees.first()).map(|attendee| attendee.value().to_owned()) }; |
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: src/importers/icalendar/cdss.rs#L183
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/importers/icalendar/cdss.rs:183:5 | 183 | / match (event.city.as_str(), event.state.as_deref()) { 184 | | ("Henrico", Some("VA")) => { 185 | | event.city = "Richmond".to_string(); 186 | | } 187 | | _ => {} 188 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 183 ~ if let ("Henrico", Some("VA")) = (event.city.as_str(), event.state.as_deref()) { 184 + event.city = "Richmond".to_string(); 185 + } |
accessing first element with `location_parts.get(0)`: src/importers/icalendar/cdss.rs#L115
warning: accessing first element with `location_parts.get(0)` --> src/importers/icalendar/cdss.rs:115:17 | 115 | location_parts.get(0).cloned().unwrap_or_default(), | ^^^^^^^^^^^^^^^^^^^^^ help: try: `location_parts.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default
you seem to be trying to use `match` for an equality check. Consider using `if`: src/importers/icalendar/balfolknl.rs#L144
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> src/importers/icalendar/balfolknl.rs:144:9 | 144 | / match event.city.as_str() { 145 | | "Lent" => event.city = "Nijmegen".to_string(), 146 | | _ => {} 147 | | } | |_________^ help: try: `if event.city.as_str() == "Lent" { event.city = "Nijmegen".to_string() }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: src/importers/icalendar/balfolknl.rs#L142
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/importers/icalendar/balfolknl.rs:142:35 | 142 | event.name = shorten_name(&raw_name); | ^^^^^^^^^ help: change this to: `raw_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636