Merge pull request #71 from CYglume/fix_getrowGDALVer

modify getrowGDALVer() to find latest GDAL
r-spatial · Nov 25, 2024 · 257e904 · 257e904
2 parents 6a5af05 + 52bdf92
commit 257e904
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/R/gdalControls.R b/R/gdalControls.R
@@ -328,9 +328,11 @@ getrowGDALVer <- function(paths) {
     if (substr(ret, 1, 4) == "GDAL" && length(ret) > 0) {
       tmp <- strsplit(x = ret, split = "GDAL ")[[1]][2]
       tmp2 <- strsplit(x = tmp, split = ", released ")[[1]][1]
-      highestVer <- max(tmp2, highestVer)
+      if (tmp2 > highestVer ){
+        highestVer <- tmp2
+        pathI <- I
+      }
     }
-    pathI <- i
   }
   options(show.error.messages = TRUE)
   options(warn = 0)
@@ -339,4 +341,4 @@ getrowGDALVer <- function(paths) {
 # getGDALVer<- function (paths){ sep = ifelse(Sys.info()['sysname']=='Windows', '\\', '/') scmd =
 # ifelse(Sys.info()['sysname']=='Windows', 'gdalinfo.exe', 'gdalinfo') tmp<- strsplit(x =
 # system(paste0(paste0(shQuote(paths$binDir[i]),sep,scmd),' --version'),intern = TRUE),split = 'GDAL ')[[1]][2]
-# gdalVersion<- strsplit(x = tmp,split = ', released ')[[1]][1] return (gdalVersion) }
+# gdalVersion<- strsplit(x = tmp,split = ', released ')[[1]][1] return (gdalVersion) }