Skip to content

Commit

Permalink
mark segfaulting test
Browse files Browse the repository at this point in the history
  • Loading branch information
paleolimbot committed Sep 21, 2023
1 parent a32ba79 commit 71dee0e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions R/read.R
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ process_cpl_read_ogr_stream = function(x, default_crs, num_features, fid_column_
df = suppressWarnings(nanoarrow::convert_array_stream(x, size = num_features))

df[is_geometry_column] = lapply(df[is_geometry_column], function(x) {
x = sf::st_as_sfc(wk::as_wkb(x))
st_set_crs(x, crs)
attributes(x) <- NULL
sf::st_as_sfc(wk::new_wk_wkb(x, crs = crs))
})

# Prefer "geometry" as the geometry column name
Expand Down
2 changes: 2 additions & 0 deletions tests/testthat/test_sp.R
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ test_that("Can convert `XY` objects to sp", {
})

test_that("Can't convert `M` dimension to sp", {
# Segfaults using the stream interface
skip_if(default_st_read_use_stream())
skip_if_not_installed("sp")
skip_if_not(sf_extSoftVersion()[["GDAL"]] >= "2.1.0")
x <- read_sf(system.file("shape/storms_xyzm_feature.shp", package = "sf"), quiet = TRUE)
Expand Down

0 comments on commit 71dee0e

Please sign in to comment.