Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Commit

Permalink
Issue #659: GH "Fork me" ribbon (#986)
Browse files Browse the repository at this point in the history
Co-authored-by: Katie Keel <[email protected]>

* Prevent Github ribbon from overlapping the sign-in button

- Done making the ribbon a bit smaller to keep ribbon visible on the
existing media breakpoints
- Bonus: open link in new tab/window

* Show ribbon from 1401px viewport size

- Increased the breakpoint to also fully show the profile dropdown
when logged in.

* Alas… let's set an even bigger breakpoint
  • Loading branch information
katrin-k authored and klappradla committed Apr 29, 2018
1 parent db7c219 commit 4dc86a0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions app/assets/stylesheets/partials/_github-ribbon.sass
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
text-indent: -999999px

// Animations
@media (max-width:1360px)
@media (max-width:1430px)
visibility: hidden
opacity: 0
-webkit-transition: visibility 0s linear 0.2s, opacity 0.2s linear
Expand All @@ -25,7 +25,7 @@
-o-transition: visibility 0s linear 0.2s, opacity 0.2s linear
transition: visibility 0s linear 0.2s, opacity 0.2s linear

@media (min-width:1360px)
@media (min-width:1430px)
visibility: visible
-webkit-transition: visibility 0s linear 0.2s, opacity 0.2s linear
-moz-transition: visibility 0s linear 0.2s, opacity 0.2s linear
Expand All @@ -37,7 +37,7 @@
position: absolute
display: block
width: 15.38em
height: 2.2em
height: 1.8em

top: 2.70em
right: -3.76em
Expand Down Expand Up @@ -74,7 +74,7 @@
// Set the text properties
color: white
font: 700 1em "Helvetica Neue", Helvetica, Arial, sans-serif
line-height: 2.2em
line-height: 1.8em
text-decoration: none
text-align: center
text-indent: 0
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/application.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ html
body class=controller.controller_name
= render 'navigation'

a.ribbon href='//github.com/rails-girls-summer-of-code/rgsoc-teams' title='Fork me on GitHub'
a.ribbon href='//github.com/rails-girls-summer-of-code/rgsoc-teams' title='Fork me on GitHub' target='_blank'

div#wrap
section.container#content
Expand Down

0 comments on commit 4dc86a0

Please sign in to comment.