Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the code documentation with indentation #863

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

cprodhomme
Copy link
Contributor

@cprodhomme cprodhomme commented Nov 12, 2023

that put the balise <code> inside the generated documentation

before:

Capture d’écran 2023-11-12 à 15 45 01 source: https://www.rubydoc.info/github/wycats/thor/Thor/Shell/Basic:ask

after:

Capture d’écran 2023-11-12 à 15 55 04

ps : i change "Pluto" by "Neptune" because Pluto is not a planet anymore

@p8
Copy link
Member

p8 commented Jan 4, 2024

Thanks @cprodhomme . Could you squash your commits?

that make the balise <code> inside the generated documentation
@cprodhomme
Copy link
Contributor Author

Thanks @cprodhomme . Could you squash your commits?

done :)

@p8
Copy link
Member

p8 commented Jan 4, 2024

Thanks!

@p8
Copy link
Member

p8 commented Jan 4, 2024

Ah sorry. Can you rebase on main as well, so there's only 1 commit?

@cprodhomme
Copy link
Contributor Author

It's already done, no ?

@p8
Copy link
Member

p8 commented Jan 5, 2024

I'm seeing 2 commits:
https://github.com/rails/thor/pull/863/commits
image

@rafaelfranca rafaelfranca merged commit d264bc0 into rails:main Feb 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants