Avoid loading bundler 2.4.22 that vendorizes thor 1.3.0 #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when thor 1.3.0 is vendorized, lcs_diff.rb emits method redefinition warnings as follows: .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:6: warning: method redefined; discarding old show_diff .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:6: warning: previous definition of show_diff was here .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:21: warning: method redefined; discarding old output_diff_line .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:21: warning: previous definition of output_diff_line was here .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:37: warning: method redefined; discarding old diff_lcs_loaded? .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:37: warning: previous definition of diff_lcs_loaded? was here
|
I forgot to describe what this patch solves. This patch fixes currently failing CI on Ruby 2.7 https://github.com/rails/thor/actions/runs/7106766044/job/19346865013 |
|
🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when thor 1.3.0 is vendorized, lcs_diff.rb emits method redefinition warnings as follows: