feat: support gsub_file erroring if gsub doesn't change anything, and add gsub_file!
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
requested changes
Feb 26, 2024
G-Rath
force-pushed
the
gsub_file-error-on-no-change
branch
from
4f92183 to
8eae746
Compare
|
@rafaelfranca can you let me know if you'd be interested in having bang methods for the other file manipulations? (either in this PR or another one) |
G-Rath
force-pushed
the
gsub_file-error-on-no-change
branch
from
8eae746 to
620b685
Compare
|
@rafaelfranca could I get a re-review on this please? |
|
@rafaelfranca would you mind re-reviewing this? we'd really like to get it landed and I think I've addressed your concerns 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈
This is a straw-person solution for #874 - overall I think it's not bad but expect changes to be requested; in particular, the option name is pretty verbose so happy if someone wants to suggest an alternative though to me really its about having
gsub_file!.A bonus to this is that anything using
gsub_filealso supports this behaviour such ascomment_linesanduncomment_lines- I think it would be nice to have bang versions of such methods too but want to get the core behaviour/implementation nailed down first.Resolves #874