Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gridview virtualization - Rendering #307

Merged
merged 44 commits into from
May 14, 2024
Merged

Gridview virtualization - Rendering #307

merged 44 commits into from
May 14, 2024

Conversation

rajdeep
Copy link
Owner

@rajdeep rajdeep commented May 14, 2024

No description provided.

rajdeep added 30 commits April 4, 2024 15:18
@rajdeep
Added logic to detect cells in viewport
920a066
@rajdeep
Detect diff for cells to be generated/reclaimed
9df34c2
@rajdeep
Added Table counterpart for Grid - to enable both attachments exist s…
9136d16 
…ide by side
@rajdeep
Added TableViewAttachment and TableViewCommand in Example App
ecb42a6
@rajdeep
Reset Grid back to original
57c605d
@rajdeep
Added prelim version of cell enqueuing/dequeuing
647454c
@rajdeep
Added prelim caching of cell's attributedText
220ad9a
@rajdeep
Updated example app to better test Tables virtualization
daf9c15
@rajdeep
Fixed re-rendering of cells on rotation
19d1054
@rajdeep
WIP - Resizing cells based on content size
622306d
@rajdeep
WIP- implemented row sizing based on text content height
0998fc9
@rajdeep
Optimized logic to update affected cell frames on cell bound changes
a0635f3
@rajdeep
More optimizations on recalculateFrameForCell
e6e0c83
@rajdeep
Fixed cell frame update to happen on table bound changes
ff0d76b
@rajdeep
Fixed viewport calculations for handling multiple attachments
fb644a8
@rajdeep
Added EditorViewDelegate callback for willRenderAttachment
3f8f365
@rajdeep
Fixed viewport for horizontal scroll rendering
ebff6b7
@rajdeep
Fixed attachment bounds mapping wrt container for viewpoty calculations
599b38d
@rajdeep
Added comment for a bug fix - TODO
386a516
@rajdeep
Fixed attachment frame intersection with viewport to account for atta…
6b8a33e 
…chment location w.r.t. container
@rajdeep
Fixed reuse of styling
6e764a5
@rajdeep
Fixed setting of editor background on change of cell contentview back…
6af0d8a 
…ground
@rajdeep
Accounted for horizontal scrolling for attachment viewport intersection
76d1656
@rajdeep
Invoke willRenderAttachment for AsyncRenderingScenario
8e0eead
@rajdeep
Fixed tests
0a6e3e0
@rajdeep
Added snapshot tests for TableViewAttachment
d6daba8
@rajdeep
Added failing test for bound changed callback
2f1e72c
@rajdeep
Fixed rendering of tables nested in another attachment
cedde77
@rajdeep
Removed commented out code
674b21b
@rajdeep
Fixed tests
5cfe363
rajdeep added 14 commits April 22, 2024 16:12
@rajdeep
Made cell style editable. Optimized recalculation of table bounds
7e670be
@rajdeep
Ignored flaky test
60a169a
@rajdeep
Use table bounds for recalculating table dimensions
ca32850
@rajdeep
Merge branch 'main' into gridview-virtualization
4a9f1b6
@rajdeep
Added code to prepare contentView for reuse
81f37a6
@rajdeep
Fixed passing in name in Utility.drawRect
a90424b
@rajdeep
Fix cell.prepareForReuse to prevent case of overlapping attachments o…
da73b62 
…n re-render
@rajdeep
Revised viewport-cell intersection logic to handle case of tables nes…
77f6c3a 
…ted in other attachments
@rajdeep
Ensure attachment is in viewport else don't calculate cellsInViewport
3ff9aa1
@rajdeep
Prevent rendering of cells when editor is hidden e.g. inside an Expand
ebe09b4
@rajdeep
Added logic for locking rect on scroll
288ffe8
@rajdeep
Made content offset changes for scroll lock a delegate callback from …
dc076b7 
…automatic
@rajdeep
FIxed ExampleApp
1bc79e0
@rajdeep
Added ability to scroll lock an unrendered cell
97d0b73
@rajdeep rajdeep merged commit 74cb1af into main May 14, 2024
3 of 4 checks passed
@rajdeep rajdeep deleted the gridview-virtualization branch May 14, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rajdeep